Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add history navigation options for dataset frames to scratch book #2396

Merged
merged 9 commits into from May 26, 2016

Conversation

Projects
None yet
3 participants
@guerler
Copy link
Contributor

commented May 23, 2016

This PR enhances the scratch book viewer such that frames may now contain optional header icons which can be customized with regard to the frame content. This functionality is demonstrated by adding basic history navigation icons for dataset display frames. This may serve as basis for future refinements of the navigation behavior, mime type detection, data type filtering, and possibly history caching. ping @bgruening

@guerler guerler force-pushed the guerler:scratchbook_slider_000 branch from 49b31b0 to a12c1cb May 25, 2016

@bgruening

This comment has been minimized.

Copy link
Member

commented May 25, 2016

I love this! So good for imaging!

@martenson

This comment has been minimized.

Copy link
Member

commented May 25, 2016

If you provide a screenshot with the PR, you might get some more feedback on UX @guerler .

@guerler

This comment has been minimized.

Copy link
Contributor Author

commented May 25, 2016

Makes sense. Here is a screenshot of the revised scratch book frame for the display of datasets:
framenavigation

@martenson

This comment has been minimized.

Copy link
Member

commented May 25, 2016

good idea & execution! 👍

@guerler guerler added status/review and removed status/WIP labels May 25, 2016

@guerler

This comment has been minimized.

Copy link
Contributor Author

commented May 25, 2016

It was @bgruening's idea, and I agree I like it too (:

@bgruening bgruening merged commit 27b70ca into galaxyproject:dev May 26, 2016

4 checks passed

api test Build finished. 213 tests run, 0 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 106 tests run, 0 skipped, 0 failed.
Details
toolshed test Build finished. 581 tests run, 0 skipped, 0 failed.
Details
@bgruening

This comment has been minimized.

Copy link
Member

commented May 26, 2016

Thanks @guerler! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.