Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EDAM topics to tools and expose in API #2397

Merged
merged 1 commit into from May 25, 2016

Conversation

Projects
None yet
5 participants
@nsoranzo
Copy link
Member

commented May 24, 2016

Suggested by @hmenager in #2379 (comment).

@nsoranzo

This comment has been minimized.

Copy link
Member Author

commented May 24, 2016

Tests are failing because http://wheels.galaxyproject.org/ is down.

@mvdbeek

This comment has been minimized.

Copy link
Member

commented May 24, 2016

Looks good, 👍 if the tests are passing.

@bgruening

This comment has been minimized.

Copy link
Member

commented May 24, 2016

We have created a single-point of failure with depot.galaxyproject.org. All over the place tests are failing, even in the deeptools repository which contains Galaxy wrappers 😭

@hmenager

This comment has been minimized.

Copy link
Contributor

commented May 24, 2016

Thank you so much @nsoranzo. There probably is somewhere a documentation for tool definition authors that should be updated, to explain what are EDAM topics and how they should be chosen. I'm willing to contribute, but need a few pointers for this!

@nsoranzo

This comment has been minimized.

Copy link
Member Author

commented May 25, 2016

@galaxybot test this

@jmchilton

This comment has been minimized.

Copy link
Member

commented May 25, 2016

Very nice - thanks so much!

@jmchilton jmchilton merged commit caec8c8 into galaxyproject:dev May 25, 2016

3 of 4 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
api test Build finished. 213 tests run, 0 skipped, 0 failed.
Details
framework test Build finished. 105 tests run, 0 skipped, 0 failed.
Details
toolshed test Build finished. 581 tests run, 0 skipped, 0 failed.
Details

@nsoranzo nsoranzo deleted the nsoranzo:edam_topics branch May 25, 2016

@nsoranzo

This comment has been minimized.

Copy link
Member Author

commented Jun 1, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.