Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancements to tool test output verification. #2409

Merged
merged 1 commit into from May 25, 2016

Conversation

Projects
None yet
3 participants
@jmchilton
Copy link
Member

commented May 25, 2016

Refactor test verification into galaxy-lib-compat module.

  • Refactor a bunch class methods in test.base.twilltestcase into module functions in galaxy.tools.verify that can more appropriately be reused as a library.
  • Move test.base.test_data to galaxy.tools.verify.test_data.
  • Move test.base.asserts to galaxy.tools.verify.asserts.

Remove duplication in execution of these methods between composite and normal test outputs. This also entailed reworking the parsing of the composite test outputs to bring them inline with normal outputs. In addition to simplify removing duplication, this means many more tests can be made over composite outputs - such as md5 checks and test assertions. I've added a new framework test tool to verify this.

Enhancements to tool test output verification.
Refactor test verification into galaxy-lib-compat module.

- Refactor a bunch class methods in ``test.base.twilltestcase`` into module functions in ``galaxy.tools.verify``.
- Move ``test.base.test_data`` to ``galaxy.tools.verify.test_data``.
- Move ``test.base.asserts`` to ``galaxy.tools.verify.asserts``.

Remove duplication in execution of these methods between composite and normal test outputs. This also entailed reworking the parsing of the composite test outputs to bring them inline with normal outputs. In addition to simplify removing duplication, this means many more tests can be made over composite outputs - such as md5 checks and test assertions. I've added a new framework test tool to verify this.

@jmchilton jmchilton force-pushed the jmchilton:test_assertions_lib branch from 66543c7 to 4765f58 May 25, 2016

elif 'value' in attrib:
file = attrib.pop( 'value', None )
else:
file = None

This comment has been minimized.

Copy link
@nsoranzo

nsoranzo May 25, 2016

Member
file = attrib.pop( 'file', attrib.pop( 'value', None ) )

@dannon dannon merged commit b41e039 into galaxyproject:dev May 25, 2016

4 checks passed

api test Build finished. 213 tests run, 0 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 105 tests run, 0 skipped, 0 failed.
Details
toolshed test Build finished. 581 tests run, 0 skipped, 0 failed.
Details

jmchilton added a commit to jmchilton/galaxy that referenced this pull request May 25, 2016

@jmchilton

This comment has been minimized.

Copy link
Member Author

commented May 25, 2016

Thanks for the merge @dannon! @nsoranzo thanks for the review - I've opened a PR with the change here - #2412.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.