Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to 4a61a4c: add hids for dataset inputs #2415

Merged
merged 1 commit into from May 26, 2016

Conversation

Projects
None yet
3 participants
@carlfeberhard
Copy link
Contributor

commented May 25, 2016

@jennaj

This comment has been minimized.

Copy link
Member

commented May 25, 2016

@carlfeberhard fabulous! thanks for this :)

@dannon

This comment has been minimized.

Copy link
Member

commented May 25, 2016

This adds the hid in parameter listing, but not the inheritance chain. Did we want to include both?

image

@dannon

This comment has been minimized.

Copy link
Member

commented May 26, 2016

Didn't hear back, so this works fine and if we wanted to follow up with inheritance chain changes they can be in a separate PR.

@dannon dannon merged commit 26ea340 into galaxyproject:dev May 26, 2016

4 checks passed

api test Build finished. 213 tests run, 0 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 106 tests run, 0 skipped, 0 failed.
Details
toolshed test Build finished. 581 tests run, 0 skipped, 0 failed.
Details

@carlfeberhard carlfeberhard deleted the carlfeberhard:fix.show-params-hid branch Jun 22, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.