Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly list subworkflows in run workflow form #2440

Merged
merged 4 commits into from Jun 2, 2016

Conversation

Projects
None yet
4 participants
@guerler
Copy link
Contributor

commented Jun 1, 2016

This PR ensures that subworkflows are properly listed as steps in the run workflow form by relaxing the rendering condition. Previously only data_input and data_collection_input were shown in addition to tool modules.

@guerler guerler force-pushed the guerler:fix_subworkflows_display branch from 1c39556 to 52a5f6e Jun 1, 2016

@bgruening

This comment has been minimized.

Copy link
Member

commented Jun 1, 2016

This was fast! Thanks for fixing!

}
return $message;
return $( '<div/>' ).addClass( 'donemessagelarge' )
.append( $( '<p/>' ).text( 'The requested workflows have been queued and datasets will appear as jobs are created - you will need to refresh your history panel to see these.' ) );

This comment has been minimized.

Copy link
@bgruening

bgruening Jun 1, 2016

Member

I think this is a useful change and un-clutters the UI. Nevertheless, can we preserve the history-ids? Let's say something like have been queued and datasets (5-45) will appear ...

This comment has been minimized.

Copy link
@dannon

dannon Jun 1, 2016

Member

Hrmm. Do we have a feeling for how many people will miss the "datasets will appear in a new history link_to_new_history"? I feel like that was added due to user demand years ago.

This comment has been minimized.

Copy link
@guerler

guerler Jun 1, 2016

Author Contributor

I would have preferred to leave the dataset details in the success message but the existing api endpoint we are planning to use does not provide that information, nor does it allow to submit the datasets to a new history or supports batch modes. However, the plan is to enhance the existing endpoint and add at least the latter two features and then add the new_history_link back to the success message. I will transfer the changes and close this PR in favor of #2077.

@guerler guerler closed this Jun 1, 2016

@guerler guerler reopened this Jun 1, 2016

@guerler

This comment has been minimized.

Copy link
Contributor Author

commented Jun 1, 2016

I re-opened this issue since it is actually not related to the api endpoint discussion.

@guerler guerler added status/review and removed status/WIP labels Jun 1, 2016

@jmchilton jmchilton merged commit a0dbcb9 into galaxyproject:dev Jun 2, 2016

4 checks passed

api test Build finished. 213 tests run, 0 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 107 tests run, 0 skipped, 0 failed.
Details
toolshed test Build finished. 581 tests run, 0 skipped, 0 failed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.