Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.04] Do not encode dict items that start with 'metadata_' in return value of api/tools/create. #2459

Merged
merged 2 commits into from Jun 7, 2016

Conversation

Projects
None yet
3 participants
@blankenberg
Copy link
Member

commented Jun 6, 2016

Resolves #2423, #2137, and galaxyproject/tools-iuc#770. However, this whole act of encoding by key.endswith('_id') is very messy.

Do not encode dict items that start with 'metadata_' in return value …
…of api/tools/create.

Resolves #2423, #2137, and galaxyproject/tools-iuc#770. However, this whole act of encoding by key.endswith('_id') is very messy.
@martenson

This comment has been minimized.

Copy link
Member

commented Jun 6, 2016

👍
Should we refactor/drop the encode_dict_ids entirely? E.g. it does not work with anything that has to do with folder ids either.

@martenson martenson added this to the 16.07 milestone Jun 6, 2016

@blankenberg

This comment has been minimized.

Copy link
Member Author

commented Jun 6, 2016

I don't think we can drop it entirely without fixing it correctly -- that is having the objects themselves or managers for the objects declare which key values should be encoded for API reporting/usage. Which we should totally do, but this is probably a bit more work.

@martenson

This comment has been minimized.

Copy link
Member

commented Jun 6, 2016

@blankenberg that is what I meant by drop; I usually try to not remove code without checking if its used...on good days 🎱

@jmchilton

This comment has been minimized.

Copy link
Member

commented Jun 7, 2016

Awesome test!

@jmchilton jmchilton merged commit 10a3f23 into galaxyproject:release_16.04 Jun 7, 2016

3 of 4 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
api test Build finished. 211 tests run, 0 skipped, 0 failed.
Details
framework test Build finished. 106 tests run, 0 skipped, 0 failed.
Details
toolshed test Build finished. 589 tests run, 0 skipped, 0 failed.
Details

@blankenberg blankenberg deleted the blankenberg:metadata-id-fix branch Jun 7, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.