Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make pykube an optional dependency since we don't have wheels for it. #2468

Merged
merged 1 commit into from Jun 8, 2016

Conversation

Projects
None yet
3 participants
@jmchilton
Copy link
Member

commented Jun 8, 2016

I should have requested this as a change to #2314.

@@ -119,6 +119,12 @@
</plugin>
<plugin id="k8s" type="runner" load="galaxy.jobs.runners.kubernetes:kubernetes">
<!-- The Kubernetes (k8s) plugin allows to send jobs to a k8s cluster which shares filesystem with Galaxy.
This will required installing pykube, activate Galaxy's virtual
environment and install pykube with using the command:

This comment has been minimized.

Copy link
@nsoranzo

nsoranzo Jun 8, 2016

Member

s/will required/will require/ or just "requires"

This comment has been minimized.

Copy link
@jmchilton

jmchilton Jun 8, 2016

Author Member

Rebased with this fix - thanks 🐦 👀!

Make pykube an optional dependency since we don't have wheels for it.
I should have requested this as a change to #2314.

Rebased with improved job conf sample comment thanks to suggestions by @nsoranzo.

@jmchilton jmchilton force-pushed the jmchilton:pykube_optional branch from 513f056 to 4147fe6 Jun 8, 2016

@martenson martenson merged commit e8c469a into galaxyproject:dev Jun 8, 2016

3 of 4 checks passed

toolshed test Build finished. 582 tests run, 0 skipped, 4 failed.
Details
api test Build finished. 213 tests run, 0 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 108 tests run, 0 skipped, 0 failed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.