Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround for circular import. Refactor. #2477

Merged
merged 3 commits into from Jun 9, 2016

Conversation

Projects
None yet
5 participants
@davebx
Copy link
Contributor

commented Jun 9, 2016

  • from tool_shed.dependencies.repository import relation_builder created a circular import.
  • Functionally equivalent definitions for directory_hash_id were in the codebase.
@nsoranzo

This comment has been minimized.

Copy link
Member

commented Jun 9, 2016

👍

@galaxybot galaxybot added the triage label Jun 9, 2016

@galaxybot galaxybot added this to the 16.07 milestone Jun 9, 2016

@jmchilton jmchilton merged commit 4da1f6a into galaxyproject:dev Jun 9, 2016

4 checks passed

api test Build finished. 213 tests run, 0 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 108 tests run, 0 skipped, 0 failed.
Details
toolshed test Build finished. 582 tests run, 0 skipped, 0 failed.
Details
@galaxybot

This comment has been minimized.

Copy link

commented Jun 9, 2016

This PR was merged without a 'kind/' tag, please correct.

@nsoranzo nsoranzo added area/framework and removed triage labels Jun 9, 2016

@davebx davebx deleted the davebx:circular_workaround branch Jun 10, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.