Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set a default for tool_dependencies_dir. #2480

Merged
merged 1 commit into from Jun 9, 2016

Conversation

Projects
None yet
3 participants
@jmchilton
Copy link
Member

commented Jun 9, 2016

This should make some obsecure errors less easy to encounter and makes it less work to get going with conda or the Tool Shed.

if 'tool_dependency_dir' in kwargs:
self.tool_dependency_dir = resolve_path( kwargs.get( "tool_dependency_dir" ), self.root )
# Location for tool dependencies.
tool_dependency_dir = kwargs.get( "tool_dependency_dir", "database/dependencies" )

This comment has been minimized.

Copy link
@martenson

martenson Jun 9, 2016

Member

this seems inconsistent with the above? (config/ vs database/)

This comment has been minimized.

Copy link
@jmchilton

jmchilton Jun 9, 2016

Author Member

Yup - config was the wrong thing to put in the config file. One second.

Set a default for tool_dependencies_dir.
This should make some obsecure errors less easy to encounter and makes it less work to get going with conda or the Tool Shed.

With config sample fix from @martenson.

@jmchilton jmchilton force-pushed the jmchilton:tool_dependencies_default branch from 489cd5d to 9f7d921 Jun 9, 2016

@martenson

This comment has been minimized.

Copy link
Member

commented Jun 9, 2016

I like this, 👍

@bgruening

This comment has been minimized.

Copy link
Member

commented Jun 9, 2016

I can remember some settings/recommendations/wiki that where using ./tool_deps/. database seems to be wrong to me - but no strong feelings about this.

@jmchilton

This comment has been minimized.

Copy link
Member Author

commented Jun 9, 2016

@bgruening We put mutable files in database - I don't know why it would be wrong. Because admins might also modify the directory?

@bgruening

This comment has been minimized.

Copy link
Member

commented Jun 9, 2016

Not wrong I just associate with database other things than dependencies - as I said no strong feelings :)

@bgruening

This comment has been minimized.

Copy link
Member

commented Jun 9, 2016

Thanks John!

@bgruening bgruening merged commit 8f647b7 into galaxyproject:dev Jun 9, 2016

4 checks passed

api test Build finished. 213 tests run, 0 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 108 tests run, 0 skipped, 0 failed.
Details
toolshed test Build finished. 582 tests run, 0 skipped, 0 failed.
Details

@martenson martenson deleted the jmchilton:tool_dependencies_default branch Jun 9, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.