Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.04] fix image generation for workflows with missing tools #2488

Merged

Conversation

Projects
None yet
4 participants
@martenson
Copy link
Member

commented Jun 10, 2016

currently this ends up with a server error

fix image generation for workflows with missing tools
currently this ends up with a server error
svg = self._workflow_to_svg_canvas( trans, stored )
except Exception:
status = 'error'
message = 'Galaxy is unable to create the svg image. Please check your workflow, there might be missing tools.'

This comment has been minimized.

Copy link
@bgruening
@bgruening

This comment has been minimized.

Copy link
Member

commented Jun 10, 2016

👍

@@ -1282,6 +1288,8 @@ def _workflow_to_svg_canvas( self, trans, stored ):
for step in workflow.steps:
# Load from database representation
module = module_factory.from_workflow_step( trans, step )
if not module:
raise Exception

This comment has been minimized.

Copy link
@nsoranzo

nsoranzo Jun 10, 2016

Member

I think an Exception would be raised anyway on the next line.

This comment has been minimized.

Copy link
@martenson

martenson Jun 11, 2016

Author Member

good point, dropped

drop unnecessary raise and fix capitalization
incorporate comments of Bjoern and Nicola

@nsoranzo nsoranzo merged commit 5245e8a into galaxyproject:release_16.04 Jun 11, 2016

4 checks passed

api test Build finished. 211 tests run, 0 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 106 tests run, 0 skipped, 0 failed.
Details
toolshed test Build finished. 589 tests run, 0 skipped, 0 failed.
Details
@nsoranzo

This comment has been minimized.

Copy link
Member

commented Jun 11, 2016

Thanks @martenson!

@martenson martenson deleted the martenson:wrap-svg-for-missing-tools branch Jun 11, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.