Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toolbox filter fixes #2499

Merged
merged 2 commits into from Jun 14, 2016

Conversation

Projects
None yet
4 participants
@dannon
Copy link
Member

commented Jun 14, 2016

Firstly, fixes the ability for users to toggle their filters -- As far as I can tell there's no reason to require a user_id here since it's locked to trans and require_login is set. This is not something admins have any interface to toggle on behalf of a user, and nothing seems to set the user_id field.

Fixes the ability for users to toggle their filters. There's no reaso…
…n to require a user_id here since it's locked to trans and require_login is set.
Fix module resolution for migrated toolbox filters path -- reuses (in…
… a hacky way) the filtering function that was duplicated to galaxy.tools.toolbox.filters. Pushing more of this functionality (the docs, etc) into the FilterFactory might be nice down the road.
@dannon

This comment has been minimized.

Copy link
Member Author

commented Jun 14, 2016

Additional fix for default tool filter locations error: https://biostar.usegalaxy.org/p/18060/. That is happening because 9b5f374 moved the toolbox and sample locations and, while the FilterFactory tried to look in both locations for tools the UI was never updated to do the same.

@jmchilton

This comment has been minimized.

Copy link
Member

commented Jun 14, 2016

Ah - yeah I clearly messed that up. Thanks for the excellent fix @dannon!

👍

@dannon dannon added status/review and removed status/WIP labels Jun 14, 2016

@dannon dannon changed the title Fixes the ability for users to toggle their filters. Toolbox filter fixes Jun 14, 2016

@galaxybot galaxybot added this to the 16.07 milestone Jun 14, 2016

@dannon dannon removed the popularity/low label Jun 14, 2016

@martenson martenson merged commit f078365 into galaxyproject:dev Jun 14, 2016

4 checks passed

api test Build finished. 219 tests run, 0 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 110 tests run, 0 skipped, 0 failed.
Details
toolshed test Build finished. 582 tests run, 0 skipped, 0 failed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.