Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This is an extra hammer swing at #1531 / #1542 #2505

Merged
merged 2 commits into from Jun 15, 2016

Conversation

Projects
None yet
5 participants
@dannon
Copy link
Member

commented Jun 15, 2016

Historically this issue has been really, really hard to reproduce and figure out what is happening.

@remimarenco Let me know if this resolves your issue.

dannon added some commits Jun 15, 2016

Try to refresh input_datasets.dataset before accessing creating_job -…
…- this is yet another attempt to resolve this being unavailable at job finish time.
@martenson

This comment has been minimized.

Copy link
Member

commented Jun 15, 2016

xref #1531 / #1542

@galaxybot galaxybot added this to the 16.07 milestone Jun 15, 2016

@remimarenco

This comment has been minimized.

Copy link
Contributor

commented Jun 15, 2016

Thanks @dannon, both commits solve the issue.

@jmchilton

This comment has been minimized.

Copy link
Member

commented Jun 15, 2016

👍 Thanks @dannon.

@martenson martenson merged commit 9d84c0b into galaxyproject:dev Jun 15, 2016

4 checks passed

api test Build finished. 219 tests run, 0 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 110 tests run, 0 skipped, 0 failed.
Details
toolshed test Build finished. 582 tests run, 0 skipped, 0 failed.
Details
@remimarenco

This comment has been minimized.

Copy link
Contributor

commented Jun 16, 2016

Fun thing, I relaunched my workflow and it failed again but it did not prevent my tool to use the data generated (maybe because it uses the extra_files...but I am not sure what is the job cycle there).

The full error is:

Traceback (most recent call last):
  File "/home/galaxy/galaxy/lib/galaxy/jobs/runners/local.py", line 128, in queue_job
    job_wrapper.finish( stdout, stderr, exit_code )
  File "/home/galaxy/galaxy/lib/galaxy/jobs/__init__.py", line 1321, in finish
    ActionBox.execute(self.app, self.sa_session, pja.post_job_action, job)
  File "/home/galaxy/galaxy/lib/galaxy/jobs/actions/post.py", line 563, in execute
    ActionBox.actions[pja.action_type].execute(app, sa_session, pja, job, replacement_dict)
  File "/home/galaxy/galaxy/lib/galaxy/jobs/actions/post.py", line 434, in execute
    sa_session.refresh(input_dataset.dataset.creating_job)
AttributeError: 'NoneType' object has no attribute 'creating_job'

Here is the screenshot, let me know if we need more informations.
screen shot 2016-06-15 at 8 23 53 pm

@remimarenco

This comment has been minimized.

Copy link
Contributor

commented Jun 16, 2016

Reverting to the first commit (f7a6a23) seems to be enough to get the workflow running apparently fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.