Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tabular display chunking #2527

Merged
merged 2 commits into from Jul 5, 2016

Conversation

Projects
None yet
4 participants
@dannon
Copy link
Member

commented Jun 22, 2016

…Skipping to the newline previously shifted the chunk past where it should read, so we subtract the skip difference from the chunk size.

This resolves https://biostar.usegalaxy.org/p/18001/

dannon added some commits Jun 22, 2016

Tabular dataset chunking fix which should prevent duplicated lines. S…
…kipping to the newline previously shifted the chunk past where it should read.
@dannon

This comment has been minimized.

Copy link
Member Author

commented Jun 22, 2016

(if I can get a few confirmations that this logic seems solid I'll actually backport to 16.01/16.04)

@galaxybot galaxybot added this to the 16.07 milestone Jun 22, 2016

@plasmid87

This comment has been minimized.

Copy link

commented Jun 22, 2016

👍 Confirmed working on a test dataset that previously showed duplicates in data preview (please see attached).

PR works without requiring any changes to existing histories / datasets.

1000-line-huge-lines-test.txt.gz

@dannon

This comment has been minimized.

Copy link
Member Author

commented Jun 22, 2016

@plasmid87 Thanks for testing it out!

@martenson

This comment has been minimized.

Copy link
Member

commented Jul 5, 2016

tested and works well; thanks @dannon and @plasmid87

@martenson martenson merged commit a630c92 into galaxyproject:dev Jul 5, 2016

4 checks passed

api test Build finished. 219 tests run, 0 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 110 tests run, 0 skipped, 0 failed.
Details
toolshed test Build finished. 582 tests run, 0 skipped, 0 failed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.