Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use self.decode_id instead of trans.security.decode_id #2529

Merged
merged 1 commit into from Jun 23, 2016

Conversation

Projects
None yet
4 participants
@nsoranzo
Copy link
Member

commented Jun 22, 2016

Because trans.security.decode_id does not cast the id to str and this reduces the use of trans.

Use self.decode_id instead of trans.security.decode_id
Because trans.security.decode_id does not cast the id to str and
this reduces the use of trans.
@carlfeberhard

This comment has been minimized.

Copy link
Contributor

commented Jun 22, 2016

Not sure why 2.7 first_startup is taking so long, but +1.

@martenson

This comment has been minimized.

Copy link
Member

commented Jun 22, 2016

@carlfeberhard it is because those are ran on OSX images and travis does not have enough of these (probably due to licensing)

@dannon dannon merged commit 7a57266 into galaxyproject:dev Jun 23, 2016

4 checks passed

api test Build finished. 219 tests run, 0 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 110 tests run, 0 skipped, 0 failed.
Details
toolshed test Build finished. 582 tests run, 0 skipped, 0 failed.
Details

@nsoranzo nsoranzo deleted the nsoranzo:decode_id branch Jun 24, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.