Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Charts revision #2531

Merged
merged 39 commits into from Jul 21, 2016

Conversation

Projects
None yet
2 participants
@guerler
Copy link
Contributor

commented Jun 22, 2016

This revision of Charts aligns coding styles to improve readability, removes chart specific libraries and links common form libraries instead. Charts input elements now use the same parameter factory as used by the tool form i.e. color picker, sliders can be used to configure visualizations. The PR also simplifies the UI by reducing the number of tabs to three. All data series can now be viewed together and are specified within regular repeat blocks:

datagroups

@guerler guerler added this to the 16.07 milestone Jun 22, 2016

@guerler guerler force-pushed the guerler:charts_revision_000 branch from 05c7891 to c46ee02 Jun 23, 2016

@guerler guerler force-pushed the guerler:charts_revision_000 branch from c46ee02 to 43a55e8 Jun 23, 2016

guerler added some commits Jun 23, 2016

@guerler guerler force-pushed the guerler:charts_revision_000 branch from 4b9d902 to 6ebc19a Jun 23, 2016

guerler added some commits Jun 23, 2016

@guerler guerler added status/review and removed status/WIP labels Jun 23, 2016

guerler added some commits Jun 25, 2016

@bgruening

This comment has been minimized.

Copy link
Member

commented Jul 5, 2016

@guerler nice work! I love how the interface get's more and more streamlined!

@guerler

This comment has been minimized.

Copy link
Contributor Author

commented Jul 18, 2016

@galaxybot test this

@bgruening

This comment has been minimized.

Copy link
Member

commented Jul 21, 2016

Tested and convinced! Can you rebase it and than let's merge it :)

@bgruening bgruening merged commit 5ff6d7a into galaxyproject:dev Jul 21, 2016

4 checks passed

api test Build finished. 224 tests run, 0 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 111 tests run, 0 skipped, 0 failed.
Details
toolshed test Build finished. 582 tests run, 0 skipped, 0 failed.
Details

@guerler guerler referenced this pull request Aug 19, 2016

Merged

Charts revision, part 2 #2820

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.