Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dataset matcher when no tool available. #2540

Merged
merged 1 commit into from Jul 5, 2016

Conversation

Projects
None yet
6 participants
@zipho
Copy link
Contributor

commented Jun 25, 2016

Broken with 80ac816.

@galaxybot galaxybot added the triage label Jun 25, 2016

@galaxybot galaxybot added this to the 16.07 milestone Jun 25, 2016

@martenson

This comment has been minimized.

Copy link
Member

commented Jun 27, 2016

@galaxybot test this

@guerler

This comment has been minimized.

Copy link
Contributor

commented Jul 5, 2016

Fix works for me. Thanks.

@@ -35,7 +35,12 @@ def hda_accessible( self, hda, check_security=True ):
accessible to user.
"""
dataset = hda.dataset
state_valid = dataset.state in self.tool.valid_input_states
has_tool = self.tool
if has_tool:

This comment has been minimized.

Copy link
@nsoranzo

nsoranzo Jul 5, 2016

Member

Out of curiosity, when did you see this to be None?

This comment has been minimized.

Copy link
@guerler

guerler Jul 5, 2016

Contributor

I noticed that loading workflows for execution fails without this fix, possibly due workflow input modules i.e. those have no associated tools, but I did not look further into it.

This comment has been minimized.

@nsoranzo nsoranzo merged commit 3eeedc6 into galaxyproject:dev Jul 5, 2016

4 checks passed

api test Build finished. 219 tests run, 0 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 110 tests run, 0 skipped, 0 failed.
Details
toolshed test Build finished. 582 tests run, 0 skipped, 0 failed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.