Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Kubernetes runner: improves handling of failed jobs #2559
This pull requests addresses some original issues related to jobs failure within the Kubernetes runner. This PR fixes:
On the last point, unfortunately, Kubernetes currently doesn't allow to tell the difference between stderr and stdout, and galaxy rightly limits to 32k the amount of data that is will save on the database for this purpose, so we still might end up in scenarios in which we lose the reason of the failure.
I have tested this functionality extensively with pipelines that have jobs failing, current version on the dev branch doesn't work well on this respect.
I didn't realise that pull #2528 wasn't merged yet, so unfortunately this pull includes 2 commits from that other pull.
Hi there! I have no way of fixing the current error, I think that this more due to an error while testing it (api test — Build finished. No test results found.), could you please re-run tests so that these can be marked as passed (or I can do something about them if they fail). Thanks!