Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gsummary.xml #2590

Merged
merged 3 commits into from Jul 15, 2016

Conversation

Projects
None yet
5 participants
@lecorguille
Copy link
Member

commented Jul 7, 2016

rpy seems not available within the Conda packages.
So I add rpy2 in the requirements.

It works for me!

I ❤️ Conda

Futhermore, I added the stdio tag because it raise the same error message mentionned in this issue:
#2541

Update gsummary.xml
rpy seems not available within the Conda packages. 
So I add rpy2 in the requirements.

It works for me! I ❤️ Conda

@galaxybot galaxybot added the triage label Jul 7, 2016

@galaxybot galaxybot added this to the 16.07 milestone Jul 7, 2016

<stdio>
<exit_code range="1" level="fatal" />
</stdio>
<command>ptyhon $__tool_directory__/gsummary.py $input $out_file1 "$cond"</command>

This comment has been minimized.

Copy link
@bgruening

bgruening Jul 7, 2016

Member

input and out_file1 should be quoted as well

This comment has been minimized.

Copy link
@lecorguille

lecorguille Jul 7, 2016

Author Member

I never do that but OK!

@jmchilton

This comment has been minimized.

Copy link
Member

commented Jul 11, 2016

If we are going to depend on rpy2 can we drop the rpy requirement? If that can be changed, this looks good and I'll merge it.

Update gsummary.xml
Delete r and rpy deps
@lecorguille

This comment has been minimized.

Copy link
Member Author

commented Jul 12, 2016

@jmchilton Sure! I just didn't want to alter too much the original tool.

@martenson

This comment has been minimized.

Copy link
Member

commented Jul 12, 2016

@galaxybot test this

@jmchilton jmchilton merged commit 0480e5e into galaxyproject:dev Jul 15, 2016

4 checks passed

api test Build finished. 220 tests run, 0 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 110 tests run, 0 skipped, 0 failed.
Details
toolshed test Build finished. 582 tests run, 0 skipped, 0 failed.
Details
@jmchilton

This comment has been minimized.

Copy link
Member

commented Jul 15, 2016

Awesome sauce - thank you kindly!

#rpy2rpy2 lives

@martenson

This comment has been minimized.

Copy link
Member

commented Jul 15, 2016

ha, that hastag is older than me :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.