Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the neostore (neo4j db) for noe4jdb dataset #2605

Merged
merged 10 commits into from Jul 25, 2016

Conversation

Projects
None yet
5 participants
@zipho
Copy link
Contributor

commented Jul 11, 2016

The neostore is a composite datatype for noe4jdb dataset.

The neostore datatype is currently a dependent to the neo4j interactive environment.

A pull request for the GIE: bxlab#34

A tool that utilizes this composite datatype: https://testtoolshed.g2.bx.psu.edu/view/sanbi-uwc/build_ctb_gene/74ad74a4be56

zipho added some commits Jul 11, 2016

Merge pull request #1 from zipho/neostore_datatype
Added the neostore (neo4j db) for noe4jdb dataset interactive

@galaxybot galaxybot added the triage label Jul 11, 2016

@galaxybot galaxybot added this to the 16.07 milestone Jul 11, 2016

derived from html - composite datatype elements
stored in extra files path
"""
#def __init__(self):

This comment has been minimized.

Copy link
@nturaga

nturaga Jul 12, 2016

Contributor

I guess these commented lines are not needed. @zipho

This comment has been minimized.

Copy link
@zipho

zipho Jul 13, 2016

Author Contributor

Thanks @nturaga .. removed those.

zipho added some commits Jul 13, 2016

@nturaga

This comment has been minimized.

Copy link
Contributor

commented Jul 13, 2016

@zipho It'd be super if you can provide a small test case for this data type under galaxy/test-data and add it to your PR.

@zipho

This comment has been minimized.

Copy link
Contributor Author

commented Jul 13, 2016

@nturaga The datatype is the dependency of neo4j GIE #2610 and dataset of this type will be produced by the build_ctb_gene tool. https://testtoolshed.g2.bx.psu.edu/view/sanbi-uwc/build_ctb_gene/74ad74a4be56

I assume by test-case, you mean i should add sample dataset of this datatype? However I just realized I could disable the upload for this datatype for now, as it's not currently a requirement for the tool.

@nturaga

This comment has been minimized.

Copy link
Contributor

commented Jul 13, 2016

@zipho Yes, i meant add a sample dataset of this datatype to galaxy/test-data.

@zipho

This comment has been minimized.

Copy link
Contributor Author

commented Jul 14, 2016

@nturaga Added a neostore.zip sample datatype into galaxy/test-data . Upload for the datatype is set to False.

@jmchilton

This comment has been minimized.

Copy link
Member

commented Jul 18, 2016

@galaxybot test this

@nturaga

This comment has been minimized.

Copy link
Contributor

commented Jul 18, 2016

@galaxybot test this

@jmchilton

This comment has been minimized.

Copy link
Member

commented Jul 20, 2016

Is neostore.zip as small as can be? It will add almost a Mb to the repo size - I'm okay with this but if it can be smaller that would be better.

@zipho

This comment has been minimized.

Copy link
Contributor Author

commented Jul 25, 2016

@jmchilton I managed to reduce the size of neostore.zip to 8.0 K

@zipho

This comment has been minimized.

Copy link
Contributor Author

commented Jul 25, 2016

Not sure why this fails all of sudden as I only added the noestore zip file.

@mvdbeek

This comment has been minimized.

Copy link
Member

commented Jul 25, 2016

The test-failures may coincide with a new flake8 version that has been uploaded to pypi today.
I'm having the same problem in #2554

@jmchilton

This comment has been minimized.

Copy link
Member

commented Jul 25, 2016

Awesome sauce - thanks for working with us on this! I'm very excited to see exciting neo4j applications on Galaxy.

@jmchilton jmchilton merged commit 5e49868 into galaxyproject:dev Jul 25, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.