Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tool test for what happens when output filter throws exception. #2631

Merged
merged 2 commits into from Jul 21, 2016

Conversation

Projects
None yet
3 participants
@jmchilton
Copy link
Member

commented Jul 19, 2016

Run new test with:

./run_tests.sh -framework -id output_filter_exception_1

xref galaxyproject/tools-iuc#883
xref galaxyproject/planemo@a066afb
xref galaxy-iuc/standards#31

Add tool test for what happens when output filter throws exception.
Run new test with:

```
./run_tests.sh -framework -id output_filter_exception_1
```

xref galaxyproject/tools-iuc#883
xref galaxyproject/planemo@a066afb
xref galaxy-iuc/standards#31
<data format="txt" from_work_dir="1" name="out_1">
</data>
<data format="txt" from_work_dir="2" name="out_2">
<filter>opitons['adv_opt1'] is True</filter>

This comment has been minimized.

Copy link
@nsoranzo

nsoranzo Jul 19, 2016

Member

s/opitons/options/

This comment has been minimized.

Copy link
@jmchilton

jmchilton Jul 21, 2016

Author Member

Fixed, good catch!

@galaxybot galaxybot added the triage label Jul 19, 2016

@galaxybot galaxybot added this to the 16.07 milestone Jul 19, 2016

@nsoranzo

This comment has been minimized.

Copy link
Member

commented Jul 21, 2016

👍 Thanks @jmchilton!

@nsoranzo

This comment has been minimized.

Copy link
Member

commented Jul 21, 2016

Framework tests pass locally, merging.

@nsoranzo nsoranzo merged commit 47f25f1 into galaxyproject:dev Jul 21, 2016

3 of 4 checks passed

framework test Build finished. No test results found.
Details
api test Build finished. 224 tests run, 0 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
toolshed test Build finished. 582 tests run, 0 skipped, 0 failed.
Details
@jmchilton

This comment has been minimized.

Copy link
Member Author

commented Jul 21, 2016

Thanks @nsoranzo!

@nsoranzo nsoranzo deleted the jmchilton:output_filter_exception branch Dec 20, 2018

@galaxyproject galaxyproject deleted a comment from galaxybot Dec 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.