Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly initialize datasets when workflow is loaded for execution #2632

Merged
merged 1 commit into from Jul 21, 2016

Conversation

Projects
None yet
4 participants
@guerler
Copy link
Contributor

commented Jul 19, 2016

When loading the workflow form, datasets are not initialized on module injection instead they are served as RuntimeValues formely as DummyDatasets. As a consequence data dependent input parameters such as e.g. data columns are not resolved i.e. no options are shown unless refreshed. This PR fixes the issue and ensures that unlinked datasets are initialized properly on load such that these dynamic option fields are resolved on start up without the need for an additional refresh. It can be tested by loading a single step workflow containing the merge tool without modifying any parameters with and without this fix.

columnyesno

@guerler guerler added this to the 16.10 milestone Jul 19, 2016

@guerler

This comment has been minimized.

Copy link
Contributor Author

commented Jul 19, 2016

@galaxybot test this

2 similar comments
@guerler

This comment has been minimized.

Copy link
Contributor Author

commented Jul 20, 2016

@galaxybot test this

@guerler

This comment has been minimized.

Copy link
Contributor Author

commented Jul 20, 2016

@galaxybot test this

@guerler guerler added status/review and removed status/WIP labels Jul 20, 2016

@jmchilton jmchilton merged commit 8d24fbe into galaxyproject:dev Jul 21, 2016

4 checks passed

api test Build finished. 223 tests run, 0 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 110 tests run, 0 skipped, 0 failed.
Details
toolshed test Build finished. 582 tests run, 0 skipped, 0 failed.
Details
@dannon

This comment has been minimized.

Copy link
Member

commented Jul 21, 2016

+1, was just testing this locally, works for me.

@guerler

This comment has been minimized.

Copy link
Contributor Author

commented Jul 21, 2016

Cool. Thanks.

@martenson martenson modified the milestones: 16.07, 16.10 Jul 27, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.