Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize get_file_peek() #2637

Merged
merged 2 commits into from Jul 21, 2016

Conversation

Projects
None yet
2 participants
@nsoranzo
Copy link
Member

commented Jul 20, 2016

last_line was always the empty string because line is read with readline() and therefore '\n' is always its last character (if it is present). This is a follow-up to #2556.

Also fix smart_str() doctests which were silently failing.

nsoranzo added some commits Jul 20, 2016

Optimize get_file_peek()
last_line was always the empty string because line is read with readline()
and therefore '\n' is always its last character (if it is present).

Follow-up to #2556.
Fix smart_str doctest
Docstrings should start with 'u"""' if containing Unicode characters (see
also PEP 257).
Backslashes should be doubled in docstrings (or raw strings should be used,
but the 'ur' prefix is not supported in Python3).
@nsoranzo

This comment has been minimized.

Copy link
Member Author

commented Jul 21, 2016

@galaxybot test this

@nsoranzo

This comment has been minimized.

Copy link
Member Author

commented Jul 21, 2016

Jenkins keeps having problems, tests passed locally for me.

@dannon

This comment has been minimized.

Copy link
Member

commented Jul 21, 2016

+1, tests work locally; Jenkins is just hosed.

@dannon dannon merged commit c6c22a9 into galaxyproject:dev Jul 21, 2016

2 of 4 checks passed

api test Build finished. No test results found.
Details
toolshed test Build finished. No test results found.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 110 tests run, 0 skipped, 0 failed.
Details

@nsoranzo nsoranzo deleted the nsoranzo:get_file_peek branch Jul 21, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.