Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move workflow run and history options to top, add loading indicator #2643

Merged
merged 13 commits into from Jul 22, 2016

Conversation

Projects
None yet
5 participants
@guerler
Copy link
Contributor

commented Jul 21, 2016

This PR moves the workflow execution button of the new run workflow form to the top of the screen and adds a load indicator i.e. spinner similar to the job execution spinner of regular tool forms. The history options form is also moved to the top of the screen. This is the first step, a progress bar (within the button) indicating the workflow loading progress with more detail will follow soon. Having the button at the top of the form will allow us to lazy load step forms below. It also avoids that users have to scroll through all steps which can be tedious if the workflow contains several hundred steps. In addition the PR aligns the button class patterns and adds new test cases.

workflowform

@bgruening

This comment has been minimized.

Copy link
Member

commented Jul 21, 2016

Thanks for implementing this. One of the common questions from our users.

@guerler

This comment has been minimized.

Copy link
Contributor Author

commented Jul 21, 2016

Anytime, thanks for having pointed it out.

@guerler guerler added status/review and removed status/WIP labels Jul 22, 2016

@blankenberg

This comment has been minimized.

Copy link
Member

commented Jul 22, 2016

Could we have the progress bar, the run button, etc float, so that when you scroll down the form you can always just click Run after you've configured the tools that you want?

@guerler

This comment has been minimized.

Copy link
Contributor Author

commented Jul 22, 2016

Awesome. Definitely. I am adding/experimenting with the progress bar right now in a separate PR and will add that feature too within that follow up i.e. keep the header with title and run button fixed at its screen location.

@dannon

This comment has been minimized.

Copy link
Member

commented Jul 22, 2016

Works for me.

@dannon dannon merged commit 7763aaa into galaxyproject:dev Jul 22, 2016

4 checks passed

api test Build finished. 224 tests run, 0 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 111 tests run, 0 skipped, 0 failed.
Details
toolshed test Build finished. 582 tests run, 0 skipped, 0 failed.
Details
@dannon

This comment has been minimized.

Copy link
Member

commented Jul 22, 2016

(and +1 to making it float at the header once you scroll)

I'd also change the display of the 'send results to a new history' and group that somehow, maybe. In another PR, of course :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.