Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance workflow run button to indicate workflow loading progress, keep header fixed #2647

Merged
merged 10 commits into from Jul 25, 2016

Conversation

Projects
None yet
3 participants
@guerler
Copy link
Contributor

commented Jul 22, 2016

This PR implements a progress bar for regular buttons, indicating their preparation progress i.e. when a certain function will be available. Already loaded steps can be safely edited. The PR also fixes the header to its screen location and places the steps into a scrollable div, following up on @blankenberg's suggestion. It also follows up on a suggestion of @dannon by reducing the number of form borders and regrouping the history options form. Overall its a follow up on #2643. Suggestions are very welcome. Here is the current state:

untitled

@guerler guerler added this to the 16.10 milestone Jul 22, 2016

@guerler guerler force-pushed the guerler:progress_button branch 3 times, most recently from 2d1ab6b to 809fee1 Jul 23, 2016

@guerler guerler force-pushed the guerler:progress_button branch from 809fee1 to be7210e Jul 23, 2016

@guerler guerler added status/review and removed status/WIP labels Jul 24, 2016

@guerler guerler changed the title Enhance workflow run button to indicate workflow loading progress Enhance workflow run button to indicate workflow loading progress, keep header fixed Jul 24, 2016

@guerler guerler force-pushed the guerler:progress_button branch from 44bc6b0 to 788a985 Jul 24, 2016

@guerler guerler force-pushed the guerler:progress_button branch from 788a985 to 8cf69f3 Jul 24, 2016

@dannon

This comment has been minimized.

Copy link
Member

commented Jul 25, 2016

+1, loading indicator works well.

@dannon dannon merged commit 1e291e1 into galaxyproject:dev Jul 25, 2016

4 checks passed

api test Build finished. 224 tests run, 0 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 111 tests run, 0 skipped, 0 failed.
Details
toolshed test Build finished. 582 tests run, 0 skipped, 0 failed.
Details

@martenson martenson modified the milestones: 16.07, 16.10 Jul 27, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.