Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow uploading strict BED datatypes. #2648

Merged
merged 1 commit into from Jul 23, 2016

Conversation

Projects
None yet
5 participants
@blankenberg
Copy link
Member

commented Jul 22, 2016

It all depends upon how much you are willing to trust the user.

@blankenberg

This comment has been minimized.

Copy link
Member Author

commented Jul 22, 2016

@lparsons comments, desires?

@lparsons

This comment has been minimized.

Copy link
Contributor

commented Jul 22, 2016

Not quite sure I understand the downside of this, since right now my users end up selecting a bed6 file as input a tool that requires bed12 since there is no way to distinguish the difference. While I can see there might be confusion, I would think the sniffers could tell the difference, and properly identify the filetype and thus reduce the instances of errors... So, I'm in favor of this.

@galaxybot galaxybot added this to the 16.07 milestone Jul 22, 2016

@erasche

This comment has been minimized.

Copy link
Member

commented Jul 22, 2016

👍

@erasche

This comment has been minimized.

Copy link
Member

commented Jul 22, 2016

@galaxybot test this

@bgruening

This comment has been minimized.

Copy link
Member

commented Jul 23, 2016

more freedom, more responsibility ...

@bgruening bgruening merged commit 4752220 into galaxyproject:dev Jul 23, 2016

4 checks passed

api test Build finished. 224 tests run, 0 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 111 tests run, 0 skipped, 0 failed.
Details
toolshed test Build finished. 582 tests run, 0 skipped, 0 failed.
Details
@galaxybot

This comment has been minimized.

Copy link

commented Jul 23, 2016

This PR was merged without a 'kind/' tag, please correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.