Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce server sided refresh requests to changes in data associated input fields #2652

Merged
merged 1 commit into from Jul 27, 2016

Conversation

Projects
None yet
3 participants
@guerler
Copy link
Contributor

commented Jul 25, 2016

This PR avoids server sided form refresh requests when numeric or text fields are modified which would significantly reduce the number of requests while configuring tools. A refresh is triggered when data assoicated fields are modified, or fields specified with the refresh_on_change=True flag. A refresh is also triggered when repeat blocks are removed or added, or a conditional parameter is modified.

@guerler guerler added this to the 16.10 milestone Jul 25, 2016

@guerler guerler force-pushed the guerler:reduce_refreshs branch 3 times, most recently from 1a6a550 to 4f27d62 Jul 25, 2016

@guerler guerler added status/review and removed status/WIP labels Jul 26, 2016

@guerler guerler force-pushed the guerler:reduce_refreshs branch from 4f27d62 to 1cdc532 Jul 26, 2016

@dannon

This comment has been minimized.

Copy link
Member

commented Jul 27, 2016

Nice, cuts down on build requests a lot.

@dannon dannon merged commit fa4085b into galaxyproject:dev Jul 27, 2016

4 checks passed

api test Build finished. 224 tests run, 0 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 111 tests run, 0 skipped, 0 failed.
Details
toolshed test Build finished. 582 tests run, 0 skipped, 0 failed.
Details

@martenson martenson modified the milestones: 16.07, 16.10 Jul 27, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.