Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import pyparsing in testing so twill's older version doesn't get loaded. #2656

Merged
merged 1 commit into from Jul 26, 2016

Conversation

Projects
None yet
4 participants
@jmchilton
Copy link
Member

commented Jul 26, 2016

There are unintended consequences if not, such as svgwrite not loading properly.

@martenson

This comment has been minimized.

Copy link
Member

commented Jul 26, 2016

@jmchilton F401 'pyparsing' imported but unused

@galaxybot galaxybot added this to the 16.07 milestone Jul 26, 2016

Import pyparsing in testing so twill's older version doesn't get loaded.
There are unintended consequences if not, such as svgwrite not loading properly.

@jmchilton jmchilton force-pushed the jmchilton:pyparsing_testing branch from 7a37345 to 93ba35f Jul 26, 2016

@nsoranzo

This comment has been minimized.

Copy link
Member

commented Jul 26, 2016

What about using a fork of the unmaintained twill instead? Branch 2.0 of @Cito's fork seems pretty good and does not ship an embedded pyparsing any more. This will also give us Python3 support.

@martenson

This comment has been minimized.

Copy link
Member

commented Jul 26, 2016

@nsoranzo I am +1 on using that fork but that will not make it to 16.07 so I will merge this once tests pass. Would you like to create an issue for swapping?

@nsoranzo

This comment has been minimized.

Copy link
Member

commented Jul 26, 2016

@martenson Why is that needed for 16.07?

@martenson

This comment has been minimized.

Copy link
Member

commented Jul 26, 2016

@nsoranzo I do not think it is needed, but given we have a working fix (this PR) and that the fix you mentioned would supersede this I am just saying that we don't have time to wait for it.

@martenson martenson merged commit 9607e52 into galaxyproject:dev Jul 26, 2016

4 checks passed

api test Build finished. 224 tests run, 0 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 111 tests run, 0 skipped, 0 failed.
Details
toolshed test Build finished. 582 tests run, 0 skipped, 0 failed.
Details

@nsoranzo nsoranzo referenced this pull request Jul 26, 2016

Open

Python 3 support. #1715

10 of 14 tasks complete

mvdbeek added a commit to bxlab/galaxy-hackathon that referenced this pull request Jul 26, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.