Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add import order linting using tox and flake8-import-order. #2661

Merged
merged 1 commit into from Jul 26, 2016

Conversation

Projects
None yet
4 participants
@jmchilton
Copy link
Member

commented Jul 26, 2016

Adds two tasks:

  • Add a task that just lints everything the way Galaxy's default linting is (py27-lint-imports) and don't enforce it passes on Travis.
  • Add a task that just lints a subset we expect to pass, hopefully we can grow this subset over time.

Once the inverse of the subset we are testing is just the blacklist, we can eliminate both tasks and just wrap this into Galaxy's default linting.

These tasks require an older flake8 until PyCQA/flake8-import-order#79 (comment) is part of a released version of flake8.

Add import order linting using tox and flake8-import-order.
Adds two tasks:

- Add a task that just lints everything the way Galaxy's default linting is (py27-lint-imports) and don't enforce it passes on Travis.
- Add a task that just lints a subset we expect to past, hopefully we can grow this subset over time.

Once the inverse of the subset we are testing is just the blacklist, we can eliminate bothtasks and just wrap this into Galaxy's default linting.

These tasks require an older flake8 until PyCQA/flake8-import-order#79 (comment) is part of a released version of flake8.
@nsoranzo

This comment has been minimized.

Copy link
Member

commented Jul 26, 2016

👍

@galaxybot galaxybot added this to the 16.07 milestone Jul 26, 2016

@martenson martenson merged commit 8b597ed into galaxyproject:dev Jul 26, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 111 tests run, 0 skipped, 0 failed.
Details
@jmchilton

This comment has been minimized.

Copy link
Member Author

commented Jul 26, 2016

Awesome beans - thanks for the input all.

@martenson martenson deleted the jmchilton:lint_imports branch Jul 27, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.