Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an error with getting the size of an object from Azure. Attempte… #2678

Merged
merged 1 commit into from Jul 28, 2016

Conversation

Projects
None yet
3 participants
@dannon
Copy link
Member

commented Jul 28, 2016

…d to future-proof it if the library is fixed.

Fix an error with getting the size of an object from Azure. Attempted…
… to future-proof it if the library is fixed.
@dannon

This comment has been minimized.

Copy link
Member Author

commented Jul 28, 2016

This is the bug followup mentioned in #2621

@mvdbeek

This comment has been minimized.

Copy link
Member

commented Jul 28, 2016

The toolshed test failures are unrelated, they were introduced in #2554. I'll open a PR to fix those.

@dannon

This comment has been minimized.

Copy link
Member Author

commented Jul 28, 2016

@zfrenchee To test this, you can just delete a dataset out of your object_store_cache (to force a re-fetch from azure). Try to access this deleted dataset, and prior to this change, you'd see an exception bubble up and the dataset wouldn't be fetched. This makes it all work smoothly.

@jmchilton jmchilton merged commit 05c537e into galaxyproject:dev Jul 28, 2016

3 of 4 checks passed

toolshed test Build finished. 582 tests run, 0 skipped, 8 failed.
Details
api test Build finished. 224 tests run, 0 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 111 tests run, 0 skipped, 0 failed.
Details
@jmchilton

This comment has been minimized.

Copy link
Member

commented Jul 29, 2016

Thanks for the thorough testing @dannon - looks solid to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.