Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit creation of multitudes of default, empty histories. #2684

Merged
merged 1 commit into from Jul 28, 2016

Conversation

Projects
None yet
3 participants
@dannon
Copy link
Member

commented Jul 28, 2016

This was happening for every new session using remote auth. Does anyone see a reason why we would not want to use the default history in these two spots, if it exists?

Followup PR will address associating new remote_auth sessions with the previously used history correctly, but this is a good step forward.

Limit creation of multitudes of default, empty histories. This was ha…
…ppening for every new session using remote auth
@erasche

This comment has been minimized.

Copy link
Member

commented Jul 28, 2016

Btw, for testing remote_user type services, I threw together a dead simple dockerfile a while back that might be useful. https://github.com/erasche/docker-remote-user-proxy (also from docker pull quay.io/erasche/remote-user-proxy)

@nsoranzo nsoranzo added this to the 16.07 milestone Jul 28, 2016

@nsoranzo nsoranzo merged commit 0066847 into galaxyproject:dev Jul 28, 2016

4 checks passed

api test Build finished. 224 tests run, 0 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 111 tests run, 0 skipped, 0 failed.
Details
toolshed test Build finished. 582 tests run, 0 skipped, 0 failed.
Details
@dannon

This comment has been minimized.

Copy link
Member Author

commented Jul 28, 2016

@erasche Cool! I might check that out next time I break my local external auth testing setup :)

@dannon

This comment has been minimized.

Copy link
Member Author

commented Jul 28, 2016

@nsoranzo Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.