Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.07] Fix: Remove the old HubAssembly class #2701

Merged
merged 1 commit into from Aug 3, 2016

Conversation

Projects
None yet
6 participants
@remimarenco
Copy link
Contributor

commented Aug 2, 2016

Hi!

I was looking at the datatype TrackHub which has been integrated into the core (thanks again!), and it seems we have added the old class (HubAssembly) with the new class (UCSCTrackHub).

This PR to fix it ;)

@nsoranzo

This comment has been minimized.

Copy link
Member

commented Aug 2, 2016

This was added in #2348 and moved to lib/galaxy/datatypes/tracks.py in #2646.

@galaxybot galaxybot added the triage label Aug 2, 2016

@jmchilton

This comment has been minimized.

Copy link
Member

commented Aug 2, 2016

@galaxybot test this

@martenson

This comment has been minimized.

Copy link
Member

commented Aug 2, 2016

Is this a bug or just dead code?

@dannon

This comment has been minimized.

Copy link
Member

commented Aug 3, 2016

Do we expect that anyone actually has huba datatypes that we need to worry about this breaking?

@remimarenco

This comment has been minimized.

Copy link
Contributor Author

commented Aug 3, 2016

@nsoranzo arg sorry for the confusion. I have changed the name hubAssembly / huba to UCSCTrackHub / trackhub per @bgruening comment, in this commit while the review of #2646. I understand it was a bit difficult to read, not sure how I should have notify the commit was related to the comment.

@martenson Just dead code :). It is not used anywhere, and will never be because the HubArchiveCreator tool which outputs huba extension has never been released in toolshed.

I guess it also answers to @dannon at the same time ^^. Nobody has this datatype, huba is the old extension name of my HubArchiveCreator tool output :D.

@nsoranzo

This comment has been minimized.

Copy link
Member

commented Aug 3, 2016

👍

@dannon dannon merged commit 3206199 into galaxyproject:release_16.07 Aug 3, 2016

4 checks passed

api test Build finished. 224 tests run, 0 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 111 tests run, 0 skipped, 0 failed.
Details
toolshed test Build finished. 582 tests run, 0 skipped, 0 failed.
Details
@galaxybot

This comment has been minimized.

Copy link

commented Aug 3, 2016

This PR was merged without a 'kind/' tag, please correct.

@galaxybot

This comment has been minimized.

Copy link

commented Aug 3, 2016

This PR was merged without a milestone attached.

@martenson martenson added this to the 16.07 milestone Aug 3, 2016

@martenson martenson added kind/bug and removed triage labels Aug 3, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.