Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.07] separate styles of new and old libraries fixing various ui bugs #2780

Merged
merged 1 commit into from Aug 12, 2016

Conversation

Projects
None yet
3 participants
@martenson
Copy link
Member

commented Aug 12, 2016

initially reported by @dpryan79 @bgruening
the bugs would be on the admin interface side as it was improperly tested after the recent wrapping of all CSS in .library_style_container specific selector

part of this is additional cleanup and some LESSification

@bgruening

This comment has been minimized.

Copy link
Member

commented Aug 12, 2016

Thanks @martenson!

@carlfeberhard

This comment has been minimized.

Copy link
Contributor

commented Aug 12, 2016

Looks good +1
(except for losing the spaces before the first brace? Is that just a new style your using?)

@carlfeberhard carlfeberhard merged commit 0719d83 into galaxyproject:release_16.07 Aug 12, 2016

4 checks passed

api test Build finished. 224 tests run, 0 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 111 tests run, 0 skipped, 0 failed.
Details
toolshed test Build finished. 582 tests run, 0 skipped, 0 failed.
Details
@martenson

This comment has been minimized.

Copy link
Member Author

commented Aug 12, 2016

@carlfeberhard the file was a mess using 3 styles so I chose one - I do not have a preference (in hindsight I should have followed base.less)

@martenson

This comment has been minimized.

Copy link
Member Author

commented Aug 12, 2016

base.less also has multiple styles :/

#content_table td{
.toolMenuAndView .toolForm
{
.icon-button.tag {
@carlfeberhard

This comment has been minimized.

Copy link
Contributor

commented Aug 12, 2016

@martenson no worries! not a crit - just curious. less can be somewhat strange with it's parsing. Use any style you prefer.

edit: re-read my comment - sorry if that wasn't clear

@martenson martenson deleted the martenson:lib-style-fix branch Aug 14, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.