Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.07] API, history contents: allow 'source' in payload #2809

Merged
merged 1 commit into from Aug 17, 2016

Conversation

Projects
None yet
3 participants
@carlfeberhard
Copy link
Contributor

commented Aug 17, 2016

In create, checks both kwd and payload for 'source' parameter when
creating a new hdca. This allows source to be passed in the body and
not query string.

This fixes the copy call in history-contents when copying an hdca
by drag and drop in the multi history view.

Fixes: #2807

API, history contents: allow 'source' in payload
In create, checks both kwd and payload for 'source' parameter when
creating a new hdca. This allows source to be passed in the body and
not query string.

This fixes the copy call in history-contents when copying an hdca
by drag and drop in the multi history view.

@carlfeberhard carlfeberhard added this to the 16.07 milestone Aug 17, 2016

@carlfeberhard carlfeberhard changed the title API, history contents: allow 'source' in payload [16.07] API, history contents: allow 'source' in payload Aug 17, 2016

@carlfeberhard

This comment has been minimized.

Copy link
Contributor Author

commented Aug 17, 2016

Hmm. Not sure why the build artifacts are being shown as changed. Taking out of WIP.

@dannon

This comment has been minimized.

Copy link
Member

commented Aug 17, 2016

@carlfeberhard I've been seeing some of that lately too. My random guess is that it's differing versions of nodejs (or something else in the stack) causing the bundles to be different due to sorting/packing/whatever algorithm changes.

@martenson

This comment has been minimized.

Copy link
Member

commented Aug 17, 2016

@dannon @carlfeberhard I agree, that's what it was the last two times I think. You only need one person to differ in the buildstack and we see these :/

@carlfeberhard

This comment has been minimized.

Copy link
Contributor Author

commented Aug 17, 2016

You're both probably right. Hopefully we can get the artifacts out soon.

@martenson martenson merged commit 6c24688 into galaxyproject:release_16.07 Aug 17, 2016

4 checks passed

api test Build finished. 224 tests run, 0 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 111 tests run, 0 skipped, 0 failed.
Details
toolshed test Build finished. 582 tests run, 0 skipped, 0 failed.
Details

@carlfeberhard carlfeberhard deleted the carlfeberhard:fix.hdca-dnd branch Aug 24, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.