Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update rename dataset action to accept . in repeat input parameters #3197

Merged

Conversation

Projects
None yet
3 participants
@scholtalbers
Copy link
Contributor

commented Nov 18, 2016

This very minor update allows the "rename dataset action" to accept . in repeat input parameters, also when not using additional operations like '|basename'.

e.g.
for "filter bam" 0.0.1: #{input_bams_0.input_bam} and #{input_bams_0.input_bam|basename} work.
And for "filter bam" 0.0.2: #{input_bams1} and #{input_bams2|basename} work.

This has only been tested tiny workflows and only seems to work on tools/workflow steps not generating collections. See all other open issues for that...
This might help the issue #2346 although that might be more about the proper help_text that lists the available input dataset variable names..

update rename dataset action to accept . in repeat input parameters, …
…also when not using additional operations like '|basename'.

e.g. for filter bam 0.0.1: #{input_bams_0.input_bam} and #{input_bams_0.input_bam|basename} work.
And for filter bam 0.0.2: #{input_bams1} and #{input_bams2|basename} work.

@galaxybot galaxybot added the triage label Nov 18, 2016

@galaxybot galaxybot added this to the 17.01 milestone Nov 18, 2016

@jmchilton

This comment has been minimized.

Copy link
Member

commented Nov 22, 2016

@galaxybot test this

@jmchilton

This comment has been minimized.

Copy link
Member

commented Dec 20, 2016

Makes sense to me - thanks for the contribution! Sorry for the delay in merging.

@jmchilton jmchilton merged commit 306c64d into galaxyproject:dev Dec 20, 2016

4 checks passed

api test Build finished. 230 tests run, 0 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 126 tests run, 0 skipped, 0 failed.
Details
toolshed test Build finished. 580 tests run, 0 skipped, 0 failed.
Details

jmchilton added a commit to jmchilton/galaxy that referenced this pull request Jan 3, 2017

jmchilton added a commit to jmchilton/galaxy that referenced this pull request Jan 5, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.