Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tour routing tweaks, allows us to drop the model out of menu #3214

Merged
merged 1 commit into from Nov 23, 2016

Conversation

Projects
None yet
3 participants
@dannon
Copy link
Member

commented Nov 23, 2016

Ping @guerler

@dannon

This comment has been minimized.

Copy link
Member Author

commented Nov 23, 2016

Discussed with @guerler whether or not the 'if Galaxy.router' check is necessary anymore -- I think this was originally added to handle when we had a mix of pages that didn't all have a full Galaxy app, but did have a Galaxy object -- but we can remove it as soon as that's no longer the case.

@galaxybot galaxybot added this to the 17.01 milestone Nov 23, 2016

@guerler guerler merged commit fef5523 into galaxyproject:dev Nov 23, 2016

3 of 4 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
api test Build finished. 230 tests run, 0 skipped, 0 failed.
Details
framework test Build finished. 126 tests run, 0 skipped, 0 failed.
Details
toolshed test Build finished. 580 tests run, 0 skipped, 0 failed.
Details
@guerler

This comment has been minimized.

Copy link
Contributor

commented Nov 23, 2016

We talked about this and will revisit this soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.