Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ESTScan scores matrices (smat) data type #3258

Merged
merged 2 commits into from Dec 16, 2016

Conversation

Projects
None yet
4 participants
@gregvonkuster
Copy link
Contributor

commented Dec 2, 2016

No description provided.

@galaxybot galaxybot added the triage label Dec 2, 2016

@galaxybot galaxybot added this to the 17.01 milestone Dec 2, 2016

# Make sure each item is an integer.
if re.match(r"[-+]?\d+$", item) is None:
return False
fh.close()

This comment has been minimized.

Copy link
@bgruening

bgruening Dec 12, 2016

Member

If you use with the filehandle is closed automatically.

This comment has been minimized.

Copy link
@gregvonkuster

gregvonkuster Dec 12, 2016

Author Contributor

This is outside of the with block.

with open(filename, "r") as fh:
line_no += 1
if line_no > 10000:
return True

This comment has been minimized.

Copy link
@bgruening

bgruening Dec 12, 2016

Member

Why this? Do you mean False?

This comment has been minimized.

Copy link
@gregvonkuster

gregvonkuster Dec 12, 2016

Author Contributor

The intent is that if 10000 lines have been inspected and it is a smat datatype so far, then the rest of the file is likely smat as well.

@jmchilton jmchilton merged commit 147de08 into galaxyproject:dev Dec 16, 2016

4 checks passed

api test Build finished. 243 tests run, 0 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 131 tests run, 0 skipped, 0 failed.
Details
toolshed test Build finished. 580 tests run, 0 skipped, 0 failed.
Details
@jmchilton

This comment has been minimized.

Copy link
Member

commented Dec 16, 2016

Cool beans @gregvonkuster - keep up the great work!

@gregvonkuster

This comment has been minimized.

Copy link
Contributor Author

commented Dec 16, 2016

Thanks for the merge! ;)

@gregvonkuster gregvonkuster deleted the gregvonkuster:smat2 branch Dec 16, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.