Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slim down testing ``Dockerfile``. #3286

Merged
merged 1 commit into from Jan 8, 2017

Conversation

Projects
None yet
2 participants
@jmchilton
Copy link
Member

commented Dec 8, 2016

  • Remove broken CasperJS from testing Dockerfile.
  • Remove multi-process mode.

Multi-process mode was difficult to maintain and the last time I did testing at scale I found docker-galaxy-stable to be much more useful and easy to use. The test framework now supports GALAXY_TEST_EXTERNAL again so it should be easy enough to rig something up with docker-compose that actually uses a best practice container for scaling tests such as those in test/manual.

Slim down testing ``Dockerfile``.
- Remove broken CasperJS from testing Dockerfile.
- Remove multi-process mode.

Multi-process mode was difficult to maintain and the last time I did testing at scale I found docker-galaxy-stable to be much more useful and easy to use. The test framework now supports GALAXY_TEST_EXTERNAL again so it should be easy enough to rig something up with docker-compose that actually uses a best practice container for scaling tests such as those in ``test/manual``.

@jmchilton jmchilton force-pushed the jmchilton:slim_test_dockerfile branch from 4282d99 to 433b993 Dec 19, 2016

@bgruening

This comment has been minimized.

Copy link
Member

commented Jan 1, 2017

@galaxybot test this

1 similar comment
@jmchilton

This comment has been minimized.

Copy link
Member Author

commented Jan 6, 2017

@galaxybot test this

mkdir -p /opt/casperjs /casperjs && wget https://github.com/n1k0/casperjs/tarball/master -O- | tar -xzf- --strip-components=1 -C /opt/casperjs && \
ln -sf /opt/casperjs/bin/casperjs /usr/local/bin/casperjs

RUN npm install -g grunt-contrib-qunit grunt grunt-cli

This comment has been minimized.

Copy link
@bgruening

bgruening Jan 8, 2017

Member

if you include the npm install into the above RUN command you will save some more time and space

@bgruening

This comment has been minimized.

Copy link
Member

commented Jan 8, 2017

@galaxybot test this

@bgruening bgruening merged commit 64faeec into galaxyproject:dev Jan 8, 2017

4 checks passed

api test Build finished. 255 tests run, 0 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 133 tests run, 0 skipped, 0 failed.
Details
toolshed test Build finished. 580 tests run, 0 skipped, 0 failed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.