Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate more CasperJS API tests to the API test framework. #3288

Merged
merged 1 commit into from Jan 8, 2017

Conversation

Projects
None yet
2 participants
@jmchilton
Copy link
Member

commented Dec 8, 2016

  • Replace visualization tests (api-visualizations-tests.js -> test_visualizations.py).
  • Replace dataset API tests (api-dataset-tests.js -> test_datasets.py).
  • Start work on migrating history dataset API tests (api-hda-tests.js -> test_history_contents.py).
Migrate more CasperJS API tests to the API test framework.
- Replace visualization tests (api-visualizations-tests.js -> test_visualizations.py).
- Replace dataset API tests (api-dataset-tests.js -> test_datasets.py).
- Start work on migrating history dataset API tests (api-hda-tests.js -> test_history_contents.py).

@jmchilton jmchilton added this to the 17.01 milestone Dec 8, 2016

@jmchilton

This comment has been minimized.

Copy link
Member Author

commented Dec 12, 2016

@galaxybot test this

3 similar comments
@bgruening

This comment has been minimized.

Copy link
Member

commented Jan 1, 2017

@galaxybot test this

@jmchilton

This comment has been minimized.

Copy link
Member Author

commented Jan 6, 2017

@galaxybot test this

@bgruening

This comment has been minimized.

Copy link
Member

commented Jan 8, 2017

@galaxybot test this

@jmchilton

This comment has been minimized.

Copy link
Member Author

commented Jan 8, 2017

@bgruening That selenium test is going to stay yellow I think because that test doesn't have the PR watcher enabled anymore. The only tests that would potentially fail for this PR are the Travis linting tests and the API tests - and they both pass. I think this should be an easy merge.

@bgruening

This comment has been minimized.

Copy link
Member

commented Jan 8, 2017

And here we go :)

@bgruening bgruening merged commit 690b512 into galaxyproject:dev Jan 8, 2017

4 of 5 checks passed

selenium test Test scheduled.
Details
api test Build finished. 251 tests run, 0 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 133 tests run, 0 skipped, 0 failed.
Details
toolshed test Build finished. 580 tests run, 0 skipped, 0 failed.
Details
@bgruening

This comment has been minimized.

Copy link
Member

commented Jan 8, 2017

Thanks John!!!!!

@jmchilton

This comment has been minimized.

Copy link
Member Author

commented Jan 8, 2017

Thanks @bgruening!

@jmchilton jmchilton referenced this pull request Mar 31, 2017

Open

Expand API Test Coverage #3853

0 of 30 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.