Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SLURM job re-submission. #3290

Merged
merged 1 commit into from Dec 12, 2016

Conversation

Projects
None yet
4 participants
@jmchilton
Copy link
Member

commented Dec 8, 2016

Approach from @Takadonet - fixes #3289.

@natefoo

This comment has been minimized.

Copy link
Member

commented Dec 8, 2016

FWIW this does preclude future checkpointing and job recovery, but I think it's fine for now.

@jmchilton

This comment has been minimized.

Copy link
Member Author

commented Dec 8, 2016

@natefoo I feel like that largely depends on how check pointing would be implemented. I'm not sure I agree with you.

@Takadonet

This comment has been minimized.

Copy link
Contributor

commented Dec 8, 2016

Not all tools can be checkpointed.

Fix SLURM job re-submission.
Approach from @Takadonet - fixes #3289.

@jmchilton jmchilton force-pushed the jmchilton:clean_working_directory branch from 15cc654 to 767c040 Dec 12, 2016

@natefoo

This comment has been minimized.

Copy link
Member

commented Dec 12, 2016

Is there a common checkpointing system in use by applications that doesn't involve writing out some sort of status? If not the job working directory, where would this go? Anyhow, it was just a heads up to future people.

@natefoo natefoo merged commit fc5ac19 into galaxyproject:dev Dec 12, 2016

4 checks passed

api test Build finished. 243 tests run, 0 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 131 tests run, 0 skipped, 0 failed.
Details
toolshed test Build finished. 580 tests run, 0 skipped, 0 failed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.