Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Masthead Webhook bug fix #3349

Merged
merged 2 commits into from Dec 29, 2016

Conversation

Projects
None yet
5 participants
@anuprulez
Copy link
Member

commented Dec 21, 2016

This PR fixes a bug in Webhooks for masthead type. It includes an if-else-if block to check on which global object "masthead" is defined. For categories like Data Libraries, Workflows and Visualizations, it is defined directly under "Galaxy" object but for the Galaxy's home page, it is defined under "Galaxy.page". So, whenever we use "masthead" type webhook, we should look for masthead object either in "Galaxy" or "Galaxy.page".

@galaxybot galaxybot added the triage label Dec 21, 2016

@galaxybot galaxybot added this to the 17.01 milestone Dec 21, 2016

@bgruening bgruening added area/UI-UX kind/bug and removed triage labels Dec 21, 2016

@dannon

This comment has been minimized.

Copy link
Member

commented Dec 29, 2016

This is probably good for now, but it might be worth looking into unifying masthead access down the road.

@dannon dannon merged commit bb80c84 into galaxyproject:dev Dec 29, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@bgruening bgruening deleted the bgruening:mastheadwebhookextend branch Dec 29, 2016

@bgruening

This comment has been minimized.

Copy link
Member

commented Dec 29, 2016

Thanks for the merge @dannon!

@martenson

This comment has been minimized.

Copy link
Member

commented Mar 8, 2017

backporting this to 16.10 here: #3728

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.