Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a newer conda version by default #3378

Merged
merged 1 commit into from Jan 3, 2017

Conversation

Projects
None yet
5 participants
@bgruening
Copy link
Member

commented Jan 1, 2017

We were able to test most of the IUC and devteam tools as indicated here: galaxyproject/tools-iuc#1071

This PR also seem to work with latest conda:
galaxyproject/tools-devteam#375

So maybe we can upgrade dev and test it in the next month more extensively.

@mvdbeek

This comment has been minimized.

Copy link
Member

commented Jan 1, 2017

This will not upgrade pre-installed conda. Should we attempt to upgrade conda to a minimum version as well? And/or display a prominent warning to admins?

@bgruening

This comment has been minimized.

Copy link
Member Author

commented Jan 1, 2017

Not sure, I had hoped to inform admins via the release notes to upgrade conda - do you think more is needed? A warning during startup?

@mvdbeek

This comment has been minimized.

Copy link
Member

commented Jan 1, 2017

I guess release notes is enough, though I would think more people look at the startup log than the release notes.

@jmchilton jmchilton merged commit 85333d4 into dev Jan 3, 2017

4 of 5 checks passed

api test Build finished. No test results found.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
framework test Build finished. 132 tests run, 0 skipped, 0 failed.
Details
toolshed test Build finished. 580 tests run, 0 skipped, 0 failed.
Details

@jmchilton jmchilton deleted the upgrade_conda branch Jan 3, 2017

@nsoranzo

This comment has been minimized.

Copy link
Member

commented Jan 4, 2017

Should we also start using Miniconda3? That's what used in Bioconda for their testing environment.

@mvdbeek

This comment has been minimized.

Copy link
Member

commented Jan 4, 2017

Should we also start using Miniconda3? That's what used in Bioconda for their testing environment.

I'd say yes, but as long as we haven't addressed #3299 (comment) we may run into additional problems

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.