Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add diamond database as datatype #3379

Merged
merged 9 commits into from Jan 9, 2017

Conversation

Projects
None yet
6 participants
@bgruening
Copy link
Member

commented Jan 1, 2017

ping @bebatut

@galaxybot galaxybot added the triage label Jan 1, 2017

@galaxybot galaxybot added this to the 17.01 milestone Jan 1, 2017

@bgruening bgruening added area/datatypes and removed triage labels Jan 1, 2017

@bebatut

This comment has been minimized.

Copy link
Member

commented Jan 3, 2017

I tried to add a new class of binary (galaxy.datatypes.binary:DMND) and add a sniffer to detect this datatype. But I was not sure how to test it

@bgruening

This comment has been minimized.

Copy link
Member Author

commented Jan 8, 2017

@galaxybot test this

@jmchilton jmchilton merged commit f358d14 into galaxyproject:dev Jan 9, 2017

4 checks passed

api test Build finished. 255 tests run, 0 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 133 tests run, 0 skipped, 0 failed.
Details
toolshed test Build finished. 580 tests run, 0 skipped, 0 failed.
Details
@jmchilton

This comment has been minimized.

Copy link
Member

commented Jan 9, 2017

Excellent - thanks @bebatut and @bgruening!

@@ -38,6 +38,7 @@
<datatype extension="len" type="galaxy.datatypes.chrominfo:ChromInfo" display_in_upload="true">
<converter file="len_to_linecount.xml" target_datatype="linecount" />
</datatype>
<datatype extension="dmnd" type="galaxy.datatypes.binary:Binary:DMND" subclass="True" display_in_upload="false"/>

This comment has been minimized.

Copy link
@mvdbeek

mvdbeek Oct 15, 2018

Member

Is there a reason why this shouldn't be uploaded ? Given the sniffer is there we might just flip that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.