Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test cases & small enhancement to workflow renaming PJAs. #3381

Merged
merged 3 commits into from Jan 8, 2017

Conversation

Projects
None yet
2 participants
@jmchilton
Copy link
Member

commented Jan 3, 2017

See individual commits for full details but in short:

  • #3377 is included since it is required for the test cases.
  • d9ffbc4 includes test cases for existing functionality including #662 and the recently merged #3197.
  • a18b24e implements renaming output datasets based on input collections - this is my reading of #2346 (more work to do in this area but a solid step forward I think)
@jmchilton

This comment has been minimized.

Copy link
Member Author

commented Jan 4, 2017

Marking as WIP - those failing tests seem legitimate.

@jmchilton jmchilton added status/WIP and removed status/review labels Jan 4, 2017

@jmchilton jmchilton force-pushed the jmchilton:rename_improvements branch from af55dc1 to a18b24e Jan 5, 2017

@jmchilton

This comment has been minimized.

Copy link
Member Author

commented Jan 6, 2017

@galaxybot test this

@bgruening

This comment has been minimized.

Copy link
Member

commented Jan 8, 2017

Is this still in WIP?

@jmchilton jmchilton added status/review and removed status/WIP labels Jan 8, 2017

@jmchilton

This comment has been minimized.

Copy link
Member Author

commented Jan 8, 2017

@bgruening - Nope - ready for review/merge in my opinion. I've updated the label - thanks for reminding me.

@bgruening bgruening merged commit dad4c60 into galaxyproject:dev Jan 8, 2017

4 checks passed

api test Build finished. 248 tests run, 0 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 133 tests run, 0 skipped, 0 failed.
Details
toolshed test Build finished. 580 tests run, 0 skipped, 0 failed.
Details
@bgruening

This comment has been minimized.

Copy link
Member

commented Jan 8, 2017

Awesome thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.