Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not allow recursive replacements in PJA renames. #3395

Merged
merged 2 commits into from Jan 9, 2017

Conversation

Projects
None yet
2 participants
@jmchilton
Copy link
Member

commented Jan 9, 2017

May result in infinite loops.

With test case to demonstrate the problem and ensure the fix.

jmchilton added some commits Jan 9, 2017

Do not allow recursive replacements in PJA.
May result in infinite loops in workflow scheduling threads.

@jmchilton jmchilton added this to the 17.01 milestone Jan 9, 2017

@dannon dannon merged commit 1082385 into galaxyproject:dev Jan 9, 2017

4 checks passed

api test Build finished. 256 tests run, 0 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 133 tests run, 0 skipped, 0 failed.
Details
toolshed test Build finished. 580 tests run, 0 skipped, 0 failed.
Details

martenson added a commit that referenced this pull request Jan 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.