Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow editor UI touch up #3407

Merged
merged 30 commits into from Feb 7, 2017

Conversation

Projects
None yet
4 participants
@guerler
Copy link
Contributor

commented Jan 11, 2017

Follow-up for #3181.

  1. Fixes #1719

  2. Fixes the label handling and duplicate message display

  3. Moves the workflow storage endpoint from controller to api

  4. Introduces better model handling for forms and improves the tool model building process

  5. Adds browser-independent datalist handling using jquery's autocomplete feature

newdlist

@jmchilton

This comment has been minimized.

Copy link
Member

commented Jan 12, 2017

  • I like the datalist drop down definitely. Very clear step forward and much needed. (You should include in the PR description "Fixes #1719" 😄).
  • I like the previous editable title since that is how we want it to show up in the run form step title box and in the box title on the workflow editor. I think we could display the tool name and version on mouseover or something. But I do understand the value of the label being permanently labelled as non-unique though - that red error state indication is important and currently unimplemented. So I think this is fine with this I guess. It is a bit more basic but the utility is clear.
@guerler

This comment has been minimized.

Copy link
Contributor Author

commented Jan 12, 2017

Cool. Awesome. Ill add the label handling for tools tmw then.

guerler added some commits Jan 12, 2017

@guerler guerler changed the title [WIP] Workflow editor UI touch up Workflow editor UI touch up Jan 30, 2017

@guerler guerler removed the status/WIP label Jan 30, 2017

@galaxybot galaxybot added this to the 17.05 milestone Jan 30, 2017

name=e.workflow.name,
message="This workflow includes missing or invalid tools. It cannot be saved until the following steps are removed or the missing tools are enabled.",
errors=e.errors,
)

This comment has been minimized.

Copy link
@nsoranzo

nsoranzo Jan 31, 2017

Member

I don't think returning a dict here follows Galaxy tradition of raising an Exception if an API call fails, I'd rather remove the except block.

This comment has been minimized.

Copy link
@jmchilton

jmchilton Jan 31, 2017

Member

Additionally we already have an endpoint that does something very similar to this and it does it with a more RESTful URL if I recall correctly. Can we avoid duplicating this?

@@ -284,6 +284,7 @@ def populate_api_routes( webapp, app ):
webapp.mapper.connect( '/api/genomes/{id}/sequences', controller='genomes', action='sequences' )
webapp.mapper.resource( 'visualization', 'visualizations', path_prefix='/api' )
webapp.mapper.connect( '/api/workflows/build_module', action='build_module', controller="workflows" )
webapp.mapper.connect( '/api/workflows/{id}/save', action='save', controller="workflows" )

This comment has been minimized.

Copy link
@nsoranzo

nsoranzo Feb 6, 2017

Member

This can be removed now.

@jmchilton jmchilton merged commit d302400 into galaxyproject:dev Feb 7, 2017

5 checks passed

api test Build finished. 261 tests run, 0 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 138 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 24 tests run, 0 skipped, 0 failed.
Details
toolshed test Build finished. 580 tests run, 0 skipped, 0 failed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.