Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.10] Sanitize ui-misc.Message, implement UnescapedMessage for uses where we need html #3416

Merged
merged 3 commits into from Jan 16, 2017

Conversation

Projects
None yet
5 participants
@dannon
Copy link
Member

commented Jan 12, 2017

This is a reopen of #3412.

WIP, needs a fix to other uses of the Message component.

@dannon dannon changed the title [16.10] Reapply ui-misc.Message changes [16.10] Sanitize ui-misc.Message, implement UnescapedMessage for uses where we need html Jan 12, 2017

@dannon dannon added status/review and removed status/WIP labels Jan 13, 2017

@dannon dannon requested review from jmchilton and guerler Jan 13, 2017

@guerler

This comment has been minimized.

Copy link
Contributor

commented Jan 13, 2017

Looks good to me. Though function names should be nameName and not underscored. 👍

@dannon

This comment has been minimized.

Copy link
Member Author

commented Jan 13, 2017

@guerler Good call, one sec.

@jmchilton jmchilton merged commit 02a8a7d into galaxyproject:release_16.10 Jan 16, 2017

4 checks passed

api test Build finished. 230 tests run, 0 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 127 tests run, 0 skipped, 0 failed.
Details
toolshed test Build finished. 580 tests run, 0 skipped, 0 failed.
Details
@jmchilton

This comment has been minimized.

Copy link
Member

commented Jan 16, 2017

Great - much appreciated!

@galaxybot

This comment has been minimized.

Copy link

commented Jan 16, 2017

This PR was merged without a milestone attached.

@nsoranzo nsoranzo added this to the 17.01 milestone Jan 16, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.