Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix accidental email exposure #3417

Merged
merged 3 commits into from Jan 13, 2017

Conversation

Projects
None yet
4 participants
@erasche
Copy link
Member

commented Jan 12, 2017

erasche added some commits Jan 12, 2017

@erasche erasche added this to the 17.01 milestone Jan 12, 2017

<input type="text" name="email" value="${ existing_emails }" size="40">
</input>
%endif
</input>

This comment has been minimized.

Copy link
@martenson

martenson Jan 12, 2017

Member

extra </input> ?

This comment has been minimized.

Copy link
@erasche

erasche Jan 12, 2017

Author Member

Do they not need trailing slashes

This comment has been minimized.

Copy link
@erasche

erasche Jan 12, 2017

Author Member

Oh, wow, you.re right. Loads/functions, just invalid.

@galaxybot galaxybot added the triage label Jan 12, 2017

@martenson

This comment has been minimized.

Copy link
Member

commented Jan 13, 2017

xref #3372

@martenson martenson requested a review from jmchilton Jan 13, 2017

@jmchilton
Copy link
Member

left a comment

Looks good to me and works in my testing.

@jmchilton jmchilton merged commit ec42500 into galaxyproject:dev Jan 13, 2017

4 checks passed

api test Build finished. 256 tests run, 0 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 134 tests run, 0 skipped, 0 failed.
Details
toolshed test Build finished. 580 tests run, 0 skipped, 0 failed.
Details

jmchilton added a commit to jmchilton/galaxy that referenced this pull request Jan 13, 2017

jmchilton added a commit to jmchilton/galaxy that referenced this pull request Jan 16, 2017

jmchilton added a commit to jmchilton/galaxy that referenced this pull request Jan 17, 2017

@erasche erasche deleted the erasche:fix-3372 branch Aug 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.