Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various fixes for test image Docker user switching. #3443

Merged
merged 1 commit into from Jan 22, 2017

Conversation

Projects
None yet
3 participants
@jmchilton
Copy link
Member

commented Jan 17, 2017

  • Fix if testing as user with GID 109 (fixes #3425).
  • Fix if testing as a user with any UID or GID that already exists in the container.
  • More logging to indicate the "problems" being printed to standard output in these cases are not problems.
  • Fix sqlite being readonly in the container for the test user.
Various fixes for test image Docker user switching.
- Fix if testing as user with GID 109 (fixes #3425).
- Fix if testing as a user with any UID or GID that already exists in the container.
- More logging to indicate the "problems" being printed to standard output in these cases are not problems.
- Fix sqlite being readonly in the container for the test user.
@bgruening

This comment has been minimized.

Copy link
Member

commented Jan 22, 2017

LGTM! Thansk @jmchilton!

@bgruening bgruening merged commit d9f9a31 into galaxyproject:dev Jan 22, 2017

4 checks passed

api test Build finished. 256 tests run, 0 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 134 tests run, 0 skipped, 0 failed.
Details
toolshed test Build finished. 580 tests run, 0 skipped, 0 failed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.