Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix various transiently failing Selenium tests. #3450

Merged
merged 1 commit into from Jan 19, 2017

Conversation

Projects
None yet
3 participants
@jmchilton
Copy link
Member

commented Jan 19, 2017

I'm pretty sure the problem is that I was waiting on conditions (e.g. datasets to become "ok") using the API and then assuming the state of the GUI elements was the same. Obviously though the GUI is polling the API and there is some lag there. This commit changes things to specifically wait on history panel GUI changes for given HIDs - obviously the better thing to wait on in a GUI test.

Fix various transiently failing Selenium tests.
I'm pretty sure the problem is that I was waiting on conditions (e.g. datasets to become "ok") using the API and then assuming the state of the GUI elements was the same. Obviously though the GUI is polling the API and there is some lag there. This commit changes things to specifically wait on history panel GUI changes - obviously the better thing to wait on in a GUI test.

@galaxybot galaxybot added this to the 17.05 milestone Jan 19, 2017

@dannon dannon merged commit d8f23b3 into galaxyproject:dev Jan 19, 2017

4 checks passed

api test Build finished. 256 tests run, 0 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 134 tests run, 0 skipped, 0 failed.
Details
toolshed test Build finished. 580 tests run, 0 skipped, 0 failed.
Details

@jmchilton jmchilton deleted the jmchilton:selenium_fixes_2 branch Jan 19, 2017

@jmchilton

This comment has been minimized.

Copy link
Member Author

commented Jan 19, 2017

Fantastic - thanks for the merge @dannon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.