Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix condor containers #3462

Merged
merged 1 commit into from Jan 23, 2017

Conversation

Projects
None yet
5 participants
@bgruening
Copy link
Member

commented Jan 22, 2017

fixes #3455

@galaxybot galaxybot added the triage label Jan 22, 2017

@galaxybot galaxybot added this to the 17.05 milestone Jan 22, 2017

@bgruening bgruening modified the milestones: 17.01, 17.05 Jan 22, 2017

@nsoranzo nsoranzo added area/jobs and removed area/framework labels Jan 23, 2017

@nsoranzo

This comment has been minimized.

Copy link
Member

commented Jan 23, 2017

@bgruening This was broken since it was introduced in #2278, are you sure you don't want to target 16.07 or 16.10?

@jmchilton jmchilton merged commit 00d1e15 into galaxyproject:dev Jan 23, 2017

4 checks passed

api test Build finished. 256 tests run, 0 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 135 tests run, 0 skipped, 0 failed.
Details
toolshed test Build finished. 580 tests run, 0 skipped, 0 failed.
Details
@jmchilton

This comment has been minimized.

Copy link
Member

commented Jan 23, 2017

Sorry about introducing the bug @bgruening - I'll support back porting the fix as far as you'd like - let me know.

@bgruening bgruening deleted the bgruening:fix_condor_containers branch Jan 23, 2017

@bgruening

This comment has been minimized.

Copy link
Member Author

commented Jan 23, 2017

No need to be sorry. Feel free to backport it to 16.10 if you like. One stupid question, howto re-target a PR? Do I need to close it and do a new one?

@nsoranzo

This comment has been minimized.

Copy link
Member

commented Jan 23, 2017

If it's not merged yet, you should be able to change the target branch by clicking the "Edit" button near the PR title.

@bgruening

This comment has been minimized.

Copy link
Member Author

commented Jan 23, 2017

Oh, I thought this is just for the title, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.